Add the time an activity sign-up opens to the activities page #1107
Conversation
Fix: I18n linter
There was a problem hiding this comment.
I like these changes, and they are all idiomatic. However I suggest that when an activity will be enrollable at some point in the future, that the 'enroll' button is not hidden but grayed out. This better conveys the message of "you can/must enroll to participate!"
This can be another PR, but I suggest we do it now before we forget. Hence the "requested changes."
config/locales/en.yml
Outdated
| @@ -382,6 +382,7 @@ en: | |||
| labels: | |||
| activities: | |||
| date: Date | |||
| opens_at: Signup from | |||
There was a problem hiding this comment.
Although 'Signup from' is fine, I would like to propose two alternatives to see what you prefer.
"Enrollable from", the confirmation message when you signed up for an activity says "Succesfully enrolled for this activity" and this is more consistent with that. I am not certain whether this is better.
"(Admissions) Open(s) at", not for a particular reason, just reads better imo.
There was a problem hiding this comment.
Also, shouldn't "open_at" be "open_from"? I don't know if that is more idiomatic. Yes that was a nitpick.
There was a problem hiding this comment.
Good point. I'll change the key to open_from and change the text to Enrollable from.
The button will be another PR, it isn't relevant here :)
Fixes #1100